Skip to content

Conversation

@glaforge
Copy link
Contributor

Draft PR for Gemini Java code samples

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 11, 2023
@Sita04
Copy link
Contributor

Sita04 commented Dec 11, 2023

@glaforge Thanks for the PR. Few global comments:

  1. Kindly add the corresponding testcases for the samples.

  2. Move all the files under a new directory vertexai to vertextai/snippets. This helps better organize the samples.

  3. To fix lint, you can use the Makefile in the repo root: make lint dir=vertexai/snippets

@Sita04 Sita04 self-assigned this Dec 11, 2023
Copy link

@ZhenyiQ ZhenyiQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gaillaume!

Sita04
Sita04 previously requested changes Dec 11, 2023
@glaforge glaforge marked this pull request as ready for review December 12, 2023 22:06
@glaforge glaforge requested review from a team and yoshi-approver as code owners December 12, 2023 22:06
@Sita04 Sita04 requested a review from kweinmeister December 12, 2023 22:13
@glaforge
Copy link
Contributor Author

All changes look good to me.
Thank you @Sita04

@Sita04 Sita04 dismissed their stale review December 12, 2023 23:13

contributed to the PR as a co-author

@Sita04 Sita04 assigned kweinmeister and unassigned Sita04 Dec 12, 2023
@snippet-bot
Copy link

snippet-bot bot commented Dec 12, 2023

Here is the summary of changes.

You are about to add 7 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

@ZhenyiQ ZhenyiQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Guillaume!

@Sita04 Sita04 merged commit 2a97c18 into GoogleCloudPlatform:main Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants